chore: correct comment and add TODO to move machine resolution to grpc-proxy router

This commit is contained in:
Pasha Sviderski
2025-10-02 20:12:45 +10:00
parent 59074a275f
commit 458d282357
2 changed files with 2 additions and 1 deletions
+1
View File
@@ -63,6 +63,7 @@ type VolumeClient interface {
func ProxyMachinesContext( func ProxyMachinesContext(
ctx context.Context, cli MachineClient, namesOrIDs []string, ctx context.Context, cli MachineClient, namesOrIDs []string,
) (context.Context, MachineMembersList, error) { ) (context.Context, MachineMembersList, error) {
// TODO: move the machine IP resolution to the proxy router to allow setting machine names and IDs in the metadata.
machines, err := cli.ListMachines(ctx, nil) machines, err := cli.ListMachines(ctx, nil)
if err != nil { if err != nil {
return nil, nil, fmt.Errorf("list machines: %w", err) return nil, nil, fmt.Errorf("list machines: %w", err)
+1 -1
View File
@@ -133,7 +133,7 @@ func (cli *Client) InspectService(ctx context.Context, nameOrID string) (api.Ser
machineID := "" machineID := ""
if mc.Metadata == nil { if mc.Metadata == nil {
// ListContainers was proxied to only one machine. // ListServiceContainers was proxied to only one machine.
for _, v := range machineIDByManagementIP { for _, v := range machineIDByManagementIP {
machineID = v machineID = v
break break