From 458d282357da4e462c567beb82897f7168a7c037 Mon Sep 17 00:00:00 2001 From: Pasha Sviderski Date: Thu, 2 Oct 2025 20:12:45 +1000 Subject: [PATCH] chore: correct comment and add TODO to move machine resolution to grpc-proxy router --- pkg/api/client.go | 1 + pkg/client/service.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/api/client.go b/pkg/api/client.go index 47791905..4ab440fb 100644 --- a/pkg/api/client.go +++ b/pkg/api/client.go @@ -63,6 +63,7 @@ type VolumeClient interface { func ProxyMachinesContext( ctx context.Context, cli MachineClient, namesOrIDs []string, ) (context.Context, MachineMembersList, error) { + // TODO: move the machine IP resolution to the proxy router to allow setting machine names and IDs in the metadata. machines, err := cli.ListMachines(ctx, nil) if err != nil { return nil, nil, fmt.Errorf("list machines: %w", err) diff --git a/pkg/client/service.go b/pkg/client/service.go index 2b28dbd2..014eda39 100644 --- a/pkg/client/service.go +++ b/pkg/client/service.go @@ -133,7 +133,7 @@ func (cli *Client) InspectService(ctx context.Context, nameOrID string) (api.Ser machineID := "" if mc.Metadata == nil { - // ListContainers was proxied to only one machine. + // ListServiceContainers was proxied to only one machine. for _, v := range machineIDByManagementIP { machineID = v break