philipp/uncloud
1
0
Fork 0
mirror of https://github.com/psviderski/uncloud.git synced 2026-08-26 11:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove the incorrect e2e test for updating machine endpoints with empty list

Browse Source
This commit is contained in:
Pasha Sviderski
2026-03-04 14:04:46 +10:00
parent 3c435434a8
commit 1f328e99d5
2 changed files with 1 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/machine/cluster/cluster.go
+1 -4
View File
@@ -259,10 +259,7 @@ func (c *Cluster) UpdateMachine(ctx context.Context, req *pb.UpdateMachineReques
updatedMachine.PublicIp = req.PublicIp updatedMachine.PublicIp = req.PublicIp
} }
} }
if req.Endpoints != nil { if len(req.Endpoints) > 0 {
if len(req.Endpoints) == 0 {
return nil, status.Error(codes.InvalidArgument, "endpoints cannot be empty")
}
updatedMachine.Network.Endpoints = req.Endpoints updatedMachine.Network.Endpoints = req.Endpoints
} }
test/e2e/machine_test.go
-19
View File
@@ -10,8 +10,6 @@ import (
"github.com/psviderski/uncloud/pkg/api" "github.com/psviderski/uncloud/pkg/api"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
) )
func TestMachineRename(t *testing.T) { func TestMachineRename(t *testing.T) {
@@ -361,23 +359,6 @@ func TestUpdateMachine(t *testing.T) {
assert.Equal(t, targetMachine.Machine.Network.Subnet.Bits, updatedMachine.Network.Subnet.Bits) assert.Equal(t, targetMachine.Machine.Network.Subnet.Bits, updatedMachine.Network.Subnet.Bits)
assert.Equal(t, targetMachine.Machine.Network.ManagementIp.Ip, updatedMachine.Network.ManagementIp.Ip) assert.Equal(t, targetMachine.Machine.Network.ManagementIp.Ip, updatedMachine.Network.ManagementIp.Ip)
assert.Equal(t, targetMachine.Machine.Network.PublicKey, updatedMachine.Network.PublicKey) assert.Equal(t, targetMachine.Machine.Network.PublicKey, updatedMachine.Network.PublicKey)
// Try to update with empty endpoints (should be rejected).
req = &pb.UpdateMachineRequest{
MachineId: targetMachine.Machine.Id,
Endpoints: []*pb.IPPort{},
}
_, err = cli.UpdateMachine(ctx, req)
require.Error(t, err)
st, ok := status.FromError(err)
require.True(t, ok)
assert.Equal(t, codes.InvalidArgument, st.Code())
// Verify endpoints remain unchanged.
inspected, err := cli.InspectMachine(ctx, targetMachine.Machine.Id)
require.NoError(t, err)
assert.Equal(t, newEndpoints, inspected.Machine.Network.Endpoints)
}) })
t.Run("update multiple fields simultaneously", func(t *testing.T) { t.Run("update multiple fields simultaneously", func(t *testing.T) {