From 1f328e99d5f257b34eabf3ce645ba7f7c7190c88 Mon Sep 17 00:00:00 2001 From: Pasha Sviderski Date: Wed, 4 Mar 2026 14:04:46 +1000 Subject: [PATCH] fix: remove the incorrect e2e test for updating machine endpoints with empty list --- internal/machine/cluster/cluster.go | 5 +---- test/e2e/machine_test.go | 19 ------------------- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/internal/machine/cluster/cluster.go b/internal/machine/cluster/cluster.go index 8142b77b..d2cc4143 100644 --- a/internal/machine/cluster/cluster.go +++ b/internal/machine/cluster/cluster.go @@ -259,10 +259,7 @@ func (c *Cluster) UpdateMachine(ctx context.Context, req *pb.UpdateMachineReques updatedMachine.PublicIp = req.PublicIp } } - if req.Endpoints != nil { - if len(req.Endpoints) == 0 { - return nil, status.Error(codes.InvalidArgument, "endpoints cannot be empty") - } + if len(req.Endpoints) > 0 { updatedMachine.Network.Endpoints = req.Endpoints } diff --git a/test/e2e/machine_test.go b/test/e2e/machine_test.go index fa40f3b9..62184fe8 100644 --- a/test/e2e/machine_test.go +++ b/test/e2e/machine_test.go @@ -10,8 +10,6 @@ import ( "github.com/psviderski/uncloud/pkg/api" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" - "google.golang.org/grpc/codes" - "google.golang.org/grpc/status" ) func TestMachineRename(t *testing.T) { @@ -361,23 +359,6 @@ func TestUpdateMachine(t *testing.T) { assert.Equal(t, targetMachine.Machine.Network.Subnet.Bits, updatedMachine.Network.Subnet.Bits) assert.Equal(t, targetMachine.Machine.Network.ManagementIp.Ip, updatedMachine.Network.ManagementIp.Ip) assert.Equal(t, targetMachine.Machine.Network.PublicKey, updatedMachine.Network.PublicKey) - - // Try to update with empty endpoints (should be rejected). - req = &pb.UpdateMachineRequest{ - MachineId: targetMachine.Machine.Id, - Endpoints: []*pb.IPPort{}, - } - _, err = cli.UpdateMachine(ctx, req) - require.Error(t, err) - - st, ok := status.FromError(err) - require.True(t, ok) - assert.Equal(t, codes.InvalidArgument, st.Code()) - - // Verify endpoints remain unchanged. - inspected, err := cli.InspectMachine(ctx, targetMachine.Machine.Id) - require.NoError(t, err) - assert.Equal(t, newEndpoints, inspected.Machine.Network.Endpoints) }) t.Run("update multiple fields simultaneously", func(t *testing.T) {