Miek GiebenandGitHub 6fb68c22c5 fix: correctly wait for journalctl processes to not leave zombies when streaming machine logs (#325) ...

* fix: call cmd.Wait()

Even though the context is cancelled we still need to call cmd.Wait()
after a cmd.Start() to clean up the child (reap) process. Not doing so
results in a zombie journalctl.

I have manually tested this, as I'm still not sure how to e2e test for
this in a simple manner.

Before:

```
root@uncloud2:~# ps aux|grep jou
root         313  0.0  1.2  42272 23352 ?        S<s  Apr20   0:10 /usr/lib/systemd/systemd-journald
root       15751  0.0  0.0      0     0 pts/0    Z+   07:02   0:00 [journalctl] <defunct>
root       15754  0.0  0.0      0     0 pts/0    Z+   07:02   0:00 [journalctl] <defunct>
```

After:

```
root         313  0.0  1.2  42272 23592 ?        S<s  Apr20   0:10 /usr/lib/systemd/systemd-journald
```

* follow() doesnt need wait

We can keep the wait function more contraint, as follow does not need it

Signed-off-by: Miek Gieben <miek@miek.nl>

---------

Signed-off-by: Miek Gieben <miek@miek.nl>

2026-04-22 19:00:15 +10:00

..

testdata

feat(machine-logs): add server side of journal logs (#282)

2026-04-08 18:51:52 +10:00

journal.go

fix: correctly wait for journalctl processes to not leave zombies when streaming machine logs (#325)

2026-04-22 19:00:15 +10:00

logs_test.go

refactor: simplify journal logs following, fix corrosion unit name

2026-04-08 19:38:02 +10:00

logs.go

fix: correctly wait for journalctl processes to not leave zombies when streaming machine logs (#325)

2026-04-22 19:00:15 +10:00