From deedbcb8a974490b9f3ba09212facf27180d897a Mon Sep 17 00:00:00 2001 From: Pavel Sviderski Date: Tue, 10 Dec 2024 17:37:42 +1000 Subject: [PATCH] minor validation for port --- internal/api/port.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/internal/api/port.go b/internal/api/port.go index db019848..a6e3fc68 100644 --- a/internal/api/port.go +++ b/internal/api/port.go @@ -130,6 +130,10 @@ func ParsePortSpec(port string) (PortSpec, error) { return spec, fmt.Errorf("invalid container port '%s': %w", parts[1], err) } + if parts[0] == "" { + return spec, fmt.Errorf("hostname or published port must be specified, format: " + + "hostname:container_port or published_port:container_port") + } // Try to parse the first part as port. if publishedPort, err := parsePort(parts[0]); err == nil { spec.PublishedPort = publishedPort @@ -138,9 +142,6 @@ func ParsePortSpec(port string) (PortSpec, error) { if spec.Mode == PortModeHost { return spec, fmt.Errorf("hostname cannot be specified in host mode") } - if parts[0] == "" { - return spec, fmt.Errorf("hostname must not be empty") - } spec.Hostname = parts[0] }