feat(compose): add TODO to address deployment idempotency

This commit is contained in:
Pavel Sviderski
2025-03-17 20:32:14 +10:00
parent 5bcbfc332d
commit b799b7518e
4 changed files with 8 additions and 0 deletions
+1
View File
@@ -40,6 +40,7 @@ func (cli *Client) CreateContainer(
}
containerName := fmt.Sprintf("%s-%s", spec.Name, suffix)
// TODO: calculate the spec hash and set it as a label to detect changes in the service spec.
config := &container.Config{
Cmd: spec.Container.Command,
Hostname: containerName,
+2
View File
@@ -97,6 +97,8 @@ func (s *RollingStrategy) planReplicated(
// Skip containers that are not running.
continue
}
// TODO: determine if the spec has changed by comparing the hashes.
// Refactor all the spec comparison logic below.
cs, err := c.Container.ServiceSpec()
if err == nil {
runningSpecs[c.Container.ID] = cs