From a54555cd136c584f4fd209014e978523fc72c4dd Mon Sep 17 00:00:00 2001
From: Anton Ovchinnikov <anton@tonyo.info>
Date: Mon, 21 Jul 2025 06:47:38 +0200
Subject: [PATCH] feat(deploy): Recreate container when pull_policy set to
 Always (#100)

---
 Makefile                            |  4 ---
 pkg/client/deploy/container.go      |  5 ++-
 pkg/client/deploy/container_test.go | 48 +++++++++++++++++++++++++++++
 3 files changed, 52 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index 0a2782a4..99ff1318 100644
--- a/Makefile
+++ b/Makefile
@@ -101,10 +101,6 @@ lint-and-fix: ARGS=--fix
 _lint:
 	golangci-lint run $(ARGS)
 
-# .PHONY: lint-and-fix
-# lint-and-fix: lint
-# 	ARGS="--fix"
-
 .PHONY: docs-image-push
 docs-image:
 	docker buildx build --push --platform linux/amd64,linux/arm64 -t "$(DOCS_IMAGE)" ./docs
diff --git a/pkg/client/deploy/container.go b/pkg/client/deploy/container.go
index 994bff29..f77795e7 100644
--- a/pkg/client/deploy/container.go
+++ b/pkg/client/deploy/container.go
@@ -26,7 +26,10 @@ func EvalContainerSpecChange(current api.ServiceSpec, new api.ServiceSpec) Conta
 		return ContainerNeedsRecreate
 	}
 
-	// Pull policy doesn't affect the container configuration.
+	// If pull policy is set to always, the container needs to be recreated.
+	if new.Container.PullPolicy == api.PullPolicyAlways {
+		return ContainerNeedsRecreate
+	}
 	new.Container.PullPolicy = current.Container.PullPolicy
 
 	// Save mutable container resources that can be updated without recreation.
diff --git a/pkg/client/deploy/container_test.go b/pkg/client/deploy/container_test.go
index 607f98cb..705869e8 100644
--- a/pkg/client/deploy/container_test.go
+++ b/pkg/client/deploy/container_test.go
@@ -324,6 +324,54 @@ func TestEvalContainerSpecChange_ContainerPrivileged(t *testing.T) {
 	assert.Equal(t, ContainerNeedsRecreate, EvalContainerSpecChange(newSpec, currentSpec))
 }
 
+func TestEvalContainerSpecChange_PullPolicy(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		name    string
+		current string
+		new     string
+		want    ContainerSpecStatus
+	}{
+		{
+			name:    "non-always to always",
+			current: api.PullPolicyMissing,
+			new:     api.PullPolicyAlways,
+			want:    ContainerNeedsRecreate,
+		},
+		{
+			name:    "always to always",
+			current: api.PullPolicyAlways,
+			new:     api.PullPolicyAlways,
+			want:    ContainerNeedsRecreate,
+		},
+		{
+			name:    "always to non-always",
+			current: api.PullPolicyAlways,
+			new:     api.PullPolicyMissing,
+			want:    ContainerUpToDate,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			currentSpec := api.ServiceSpec{
+				Container: api.ContainerSpec{
+					PullPolicy: tt.current,
+				},
+			}
+			newSpec := api.ServiceSpec{
+				Container: api.ContainerSpec{
+					PullPolicy: tt.new,
+				},
+			}
+
+			result := EvalContainerSpecChange(currentSpec, newSpec)
+			assert.Equal(t, tt.want, result)
+		})
+	}
+}
+
 func TestEvalContainerSpecChange_ContainerUser(t *testing.T) {
 	t.Parallel()