fix: sshcli tests

This commit is contained in:
Pasha Sviderski
2026-01-28 19:00:53 +10:00
parent 1d4dbd96ce
commit a4a8e70f9c
+27 -15
View File
@@ -18,29 +18,49 @@ func TestSSHCLIRemote_buildSSHArgs(t *testing.T) {
expected []string expected []string
}{ }{
{ {
name: "default port, no key", name: "host only",
host: "example.com",
expected: []string{"-o", "ConnectTimeout=5", "example.com"},
},
{
name: "with user",
user: "root", user: "root",
host: "example.com", host: "example.com",
port: 22,
keyPath: "",
expected: []string{"-o", "ConnectTimeout=5", "root@example.com"}, expected: []string{"-o", "ConnectTimeout=5", "root@example.com"},
}, },
{ {
name: "custom port", name: "with port",
host: "example.com",
port: 2222,
expected: []string{"-o", "ConnectTimeout=5", "-p", "2222", "example.com"},
},
{
name: "with key",
host: "example.com",
keyPath: "/path/to/key",
expected: []string{"-o", "ConnectTimeout=5", "-i", "/path/to/key", "example.com"},
},
{
name: "user and port",
user: "ubuntu", user: "ubuntu",
host: "192.168.1.10", host: "192.168.1.10",
port: 2222, port: 2222,
keyPath: "",
expected: []string{"-o", "ConnectTimeout=5", "-p", "2222", "ubuntu@192.168.1.10"}, expected: []string{"-o", "ConnectTimeout=5", "-p", "2222", "ubuntu@192.168.1.10"},
}, },
{ {
name: "with key path", name: "user and key",
user: "root", user: "root",
host: "example.com", host: "example.com",
port: 22,
keyPath: "/path/to/key", keyPath: "/path/to/key",
expected: []string{"-o", "ConnectTimeout=5", "-i", "/path/to/key", "root@example.com"}, expected: []string{"-o", "ConnectTimeout=5", "-i", "/path/to/key", "root@example.com"},
}, },
{
name: "port and key",
host: "example.com",
port: 22,
keyPath: "~/.ssh/id_rsa",
expected: []string{"-o", "ConnectTimeout=5", "-p", "22", "-i", "~/.ssh/id_rsa", "example.com"},
},
{ {
name: "all options", name: "all options",
user: "admin", user: "admin",
@@ -49,14 +69,6 @@ func TestSSHCLIRemote_buildSSHArgs(t *testing.T) {
keyPath: "~/.ssh/id_rsa", keyPath: "~/.ssh/id_rsa",
expected: []string{"-o", "ConnectTimeout=5", "-p", "2222", "-i", "~/.ssh/id_rsa", "admin@server.local"}, expected: []string{"-o", "ConnectTimeout=5", "-p", "2222", "-i", "~/.ssh/id_rsa", "admin@server.local"},
}, },
{
name: "port zero (default)",
user: "root",
host: "example.com",
port: 0,
keyPath: "",
expected: []string{"-o", "ConnectTimeout=5", "root@example.com"},
},
} }
for _, tt := range tests { for _, tt := range tests {