From 4b34c42b76d9a1c47256ac11b647292b43c5a61e Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Fri, 3 Apr 2026 01:41:16 +0200 Subject: [PATCH] refactor: modernize, remove AsPtr (#300) modernize missed this in #278, but AsPtr can also be removed here and replace with new() Signed-off-by: Miek Gieben --- pkg/api/client.go | 7 ------- pkg/client/compose/service_test.go | 6 +++--- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/pkg/api/client.go b/pkg/api/client.go index 55214d13..c17d3e49 100644 --- a/pkg/api/client.go +++ b/pkg/api/client.go @@ -60,10 +60,3 @@ type VolumeClient interface { ListVolumes(ctx context.Context, filter *VolumeFilter) ([]MachineVolume, error) RemoveVolume(ctx context.Context, machineNameOrID, volumeName string, force bool) error } - -// AsPtr returns a pointer to the given value. Useful for optional fields in API structs. -// -//go:fix inline -func AsPtr[T any](v T) *T { - return new(v) -} diff --git a/pkg/client/compose/service_test.go b/pkg/client/compose/service_test.go index eb8cec30..89206595 100644 --- a/pkg/client/compose/service_test.go +++ b/pkg/client/compose/service_test.go @@ -968,7 +968,7 @@ services: monitor: 10s `, expected: api.UpdateConfig{ - MonitorPeriod: api.AsPtr(10 * time.Second), + MonitorPeriod: new(10 * time.Second), }, }, { @@ -984,7 +984,7 @@ services: `, expected: api.UpdateConfig{ Order: api.UpdateOrderStartFirst, - MonitorPeriod: api.AsPtr(30 * time.Second), + MonitorPeriod: new(30 * time.Second), }, }, { @@ -998,7 +998,7 @@ services: monitor: 0s `, expected: api.UpdateConfig{ - MonitorPeriod: api.AsPtr(time.Duration(0)), + MonitorPeriod: new(time.Duration(0)), }, }, }