add couple TODOs

This commit is contained in:
Pavel Sviderski
2024-09-12 17:45:31 +10:00
parent bd53e3f20e
commit 3f497b5e58
2 changed files with 2 additions and 0 deletions
+1
View File
@@ -310,6 +310,7 @@ func (cli *CLI) ListMachines(ctx context.Context, clusterName string) error {
// Print the list of machines in a table format.
tw := tabwriter.NewWriter(os.Stdout, 0, 0, 3, ' ', 0)
// Print header.
// TODO: print ADDRESS instead of SUBNET which is a machine IP with prefix.
if _, err = fmt.Fprintln(tw, "NAME\tSUBNET\tPUBLIC KEY\tENDPOINTS"); err != nil {
return fmt.Errorf("write header: %w", err)
}
+1
View File
@@ -158,6 +158,7 @@ func (c *Cluster) AddMachine(ctx context.Context, req *pb.AddMachineRequest) (*p
// TODO: notify all cluster machines about the new machine so they can update their peers config.
// In PoC we just notify the local machine.
// TODO: there is a race condition with network configuration if a new cluster is initialized on the machine.
c.newMachinesCh <- m
resp := &pb.AddMachineResponse{Machine: m}