mirror of
https://github.com/psviderski/uncloud.git
synced 2026-08-26 11:03:34 +00:00
fix(machine): improve context cancellation handling during watch and sync operations
This commit is contained in:
@@ -290,6 +290,7 @@ func (c *APIClient) resubscribeWithBackoffFn(id string) func(context.Context, ui
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
return func(ctx context.Context, fromChange uint64) (*Subscription, error) {
|
return func(ctx context.Context, fromChange uint64) (*Subscription, error) {
|
||||||
|
boff := backoff.WithContext(c.newResubBackoff(), ctx)
|
||||||
return backoff.RetryWithData(func() (*Subscription, error) {
|
return backoff.RetryWithData(func() (*Subscription, error) {
|
||||||
sub, err := c.ResubscribeContext(ctx, id, fromChange)
|
sub, err := c.ResubscribeContext(ctx, id, fromChange)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -300,11 +301,14 @@ func (c *APIClient) resubscribeWithBackoffFn(id string) func(context.Context, ui
|
|||||||
"id", id, "from_change", fromChange)
|
"id", id, "from_change", fromChange)
|
||||||
return nil, backoff.Permanent(fmt.Errorf("resubscribe to %s: %w", id, err))
|
return nil, backoff.Permanent(fmt.Errorf("resubscribe to %s: %w", id, err))
|
||||||
}
|
}
|
||||||
slog.Debug("Failed to resubscribe to Corrosion query. Retrying with backoff.",
|
// Don't log retries triggered by context cancellation, the backoff will stop immediately.
|
||||||
"id", id, "from_change", fromChange, "err", err)
|
if ctx.Err() == nil {
|
||||||
|
slog.Debug("Failed to resubscribe to Corrosion query. Retrying with backoff.",
|
||||||
|
"id", id, "from_change", fromChange, "err", err)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
return sub, err
|
return sub, err
|
||||||
}, c.newResubBackoff())
|
}, boff)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -620,7 +620,7 @@ func (cc *clusterController) syncDockerContainers(ctx context.Context) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
if err := backoff.Retry(watchAndSync, boff); err != nil {
|
if err := backoff.Retry(watchAndSync, boff); err != nil {
|
||||||
if errors.Is(err, context.Canceled) {
|
if ctx.Err() != nil {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
return fmt.Errorf("watch and sync containers to cluster store: %w", err)
|
return fmt.Errorf("watch and sync containers to cluster store: %w", err)
|
||||||
|
|||||||
@@ -139,7 +139,7 @@ func (c *Controller) WatchAndSyncContainers(ctx context.Context) error {
|
|||||||
return fmt.Errorf("sync containers to cluster store: %w", err)
|
return fmt.Errorf("sync containers to cluster store: %w", err)
|
||||||
}
|
}
|
||||||
case err := <-errCh:
|
case err := <-errCh:
|
||||||
if errors.Is(err, context.Canceled) {
|
if ctx.Err() != nil {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
return fmt.Errorf("receive Docker event: %w", err)
|
return fmt.Errorf("receive Docker event: %w", err)
|
||||||
|
|||||||
Reference in New Issue
Block a user