chore: use a new uncancelled context for stopping corrosion service

This commit is contained in:
Pasha Sviderski
2025-07-25 13:03:20 +10:00
parent 614212a24c
commit 1b6130447f
2 changed files with 4 additions and 1 deletions
+3
View File
@@ -218,6 +218,9 @@ func (cc *clusterController) Run(ctx context.Context) error {
err = errGroup.Wait()
// It's safe to stop the Corrosion service after the controllers depending on it and API server are stopped.
// Use a new context with a timeout as the current context is already canceled.
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
if corroErr := cc.corroService.Stop(ctx); corroErr != nil {
err = errors.Join(err, fmt.Errorf("stop corrosion service: %w", corroErr))
} else {
+1 -1
View File
@@ -27,7 +27,7 @@ func (s *SystemdService) Start(ctx context.Context) error {
return s.startOrRestart(ctx, "start")
}
func (s *SystemdService) Stop(ctx context.Context) error {
func (s *SystemdService) Stop(_ context.Context) error {
if _, err := exec.Command("systemctl", "stop", s.Unit).Output(); err != nil {
return fmt.Errorf("systemctl stop %s: %w", s.Unit, err)
}