philipp/uncloud
1
0
Fork 0
mirror of https://github.com/psviderski/uncloud.git synced 2026-08-26 19:13:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: do not include outdated containers from the removed machine in DNS and Caddy configs

Browse Source
This commit is contained in:
Pasha Sviderski
2026-05-21 19:33:28 +10:00
parent a26af3b2ae
commit 07acb31bf3
4 changed files with 110 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/machine/cluster/cluster.go
+7
View File
@@ -334,6 +334,13 @@ func (c *Cluster) RemoveMachine(ctx context.Context, req *pb.RemoveMachineReques
return nil, status.Error(codes.InvalidArgument, "machine ID not set")
}
// Cleanup machine containers from the store that could be left if the machine is unavailable
// removed with --no-reset, or didn't have time to finish propagating changes before resetting.
if err := c.store.DeleteContainers(ctx, store.DeleteOptions{MachineIDs: []string{req.Id}}); err != nil {
slog.Error("Failed to delete container records from the cluster store for the machine being removed.",
"id", req.Id, "err", err)
}
if err := c.store.DeleteMachine(ctx, req.Id); err != nil {
if errors.Is(err, store.ErrMachineNotFound) {
return nil, status.Errorf(codes.NotFound, "machine not found: %s", req.Id)